fix: auto-fallback MCP server port when already in use - #308
Open
jsmorabito wants to merge 7 commits into
Open
Conversation
Adds a Streamable HTTP MCP server (127.0.0.1-bound, bearer-token authenticated) so Claude Desktop or any other MCP client can list, read, search, create, edit, move, and delete vault notes directly, without a separate companion plugin. Writes go through a new permission modal (create/edit/move/delete); reads run immediately. Every path is resolved and validated against the vault root to reject traversal attempts, including encoded/double-encoded variants. The MCP SDK is loaded lazily (dynamic import, gated on Platform.isDesktop && settings.mcpServerSettings.enabled) so its node:http dependency chain never executes at plugin load on mobile. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Add built-in MCP server for external vault access
esbuild's outfile pointed at ../large-language-models/ (this local dev vault's live plugin folder) as the primary build target. That path doesn't exist in a plain CI checkout, so release.yml's "Attest main.js" step — which references the bare "main.js" path — couldn't find the file (discovered while cutting the 0.24.24 release; CI's build step itself silently succeeded because esbuild auto-creates its outfile's parent directory one level above the checkout). main.js/manifest.json/styles.css now build at the repo root first (matching what release.yml expects and what CLAUDE.md documents), then get mirrored to the sibling live-vault folder only when it exists — a no-op in CI, unchanged local dev convenience otherwise.
Documents the lazy-load mobile-safety pattern (dynamic import gated on Platform.isDesktop), the obsidianmd/no-nodejs-modules lint rule's structural guard requirement, the McpPermissionModal vs. in-chat permission gate distinction, and the mcp-remote bridge workaround for clients that only accept command/args config entries.
# Conflicts: # .claude/rules/mcp-server.md # CLAUDE.md # manifest.json # package-lock.json # package.json # src/Settings/LLMSettingsModal.ts # src/main.ts # src/mcp/transport.ts # styles.css # versions.json
Each vault runs its own MCP server, but the port setting defaults identically across vaults, so enabling the server in a second or third vault hit EADDRINUSE. McpTransportServer.start() now walks forward to the next free port on EADDRINUSE (up to 20 attempts), and the plugin persists + surfaces whichever port actually got bound instead of just erroring out. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EADDRINUSE.McpTransportServer.start()now walks forward to the next free port onEADDRINUSE(up to 20 attempts) instead of just failing.Noticeexplaining the fallback, so multi-vault MCP setups (e.g. connecting Claude Desktop to several vaults at once) no longer require manually hunting for a free port before it'll start.Test plan
npm run typechecknpm run lintnpm run lint:cssnpm run buildclaude_desktop_config.jsonsnippet reflect the actual bound port.🤖 Generated with Claude Code