Add multi-condition rewrites #351
Conversation
|
|
||
| pub fn all<L, N>( | ||
| conds: Vec<Arc<dyn Condition<L, N> + Send + Sync>>, | ||
| ) -> Arc<dyn Condition<L, N> + Send + Sync> |
There was a problem hiding this comment.
We could also easily change the return type here into Arc<AndCondition<L,N>> if we wanted to (same for any with OrCondition) by making the base an and of true conditions. Little less efficient but nicer types
|
How does this interact with explanations? I thought they didn't support conditions at all. |
|
They don't interact with proofs directly, however, you mentioned Hackily for proofs, I keep track of all my preconditions (which in my case are all equalities) and then have egg give me proofs for those |
|
Oh I see, I think I misunderstood in the issue thread. |
|
Sorry for the delay here. Maybe I'm misunderstanding, but can't you already achieve multiple conditions via stacking conditional appliers? |
3 participants
As discussed in #350, adding simple wrapper structures to allow for rewrites to be conditioned on multiple conditions
(cc: @oflatt)