Skip to content

Add a rule to prohibit (and fix) trailing whitespace #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

ralphbean
Copy link
Contributor

No description provided.

@ralphbean
Copy link
Contributor Author

Thanks for the great tool!

My team is using it to help us minimize merge conflicts in our CODEOWNERS file. Ensuring that people omit trailing whitespace will help us with that.

@gasparev
Copy link
Collaborator

Hi, thanks for reaching out! I haven't touched this repo in years 😅 I've just merged this #34 to update the CI. Please update your branch so we can run the action again. The change LGTM

@ralphbean ralphbean force-pushed the trailing-whitespace branch from fbfcff1 to ab9adf2 Compare July 14, 2025 18:54
@ralphbean
Copy link
Contributor Author

Awesome! Thanks. I rebased on main.

@ralphbean ralphbean force-pushed the trailing-whitespace branch from ab9adf2 to 27cd9f1 Compare July 15, 2025 12:44
@ralphbean ralphbean force-pushed the trailing-whitespace branch from 27cd9f1 to 57f25bc Compare July 15, 2025 12:46
@ralphbean
Copy link
Contributor Author

@gasparev I think I fixed up the pre-commit issues. I had to add tests/resources/trailing_whitespace_input.txt to an ignore list for one of the pre-commit rules.

Copy link
Collaborator

@gasparev gasparev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gasparev gasparev merged commit 8db9096 into egen:main Jul 15, 2025
12 checks passed
@gasparev
Copy link
Collaborator

@ralphbean I've just pushed a new release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants