Add permissionless stale execution cleanup mechanism#6
Open
e3o8o wants to merge 1 commit into
Open
Conversation
Pre-loaded executions whose state no longer matches persist in storage indefinitely. This adds a cleanup mechanism to Rollups.sol: - _executionBlockLoaded mapping tracks when each execution was stored (separate from Execution struct to avoid breaking ZK proof inputs) - MAX_EXECUTION_AGE = 256 blocks (~51min at 12s/slot) - cleanupStaleExecutions(actionHash, maxAge) is permissionless - Cleanup requires BOTH: expired age AND state mismatch - getExecutionCount() and getExecutionBlockLoaded() view helpers 12 tests covering stale removal, preservation of valid entries, custom maxAge, selective removal, permissionless access, and edge cases.
e3o8o
force-pushed
the
feat/stale-execution-cleanup
branch
from
faa3040 to
d75df34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-loaded executions whose state no longer matches persist in storage indefinitely. This adds a cleanup mechanism to Rollups.sol.
The _executionBlockLoaded mapping tracks when each execution was stored (separate from Execution struct to avoid breaking ZK proof inputs). There is a MAX_EXECUTION_AGE = 256 blocks (~51min at 12s/slot) and cleanupStaleExecutions(actionHash, maxAge) is permissionless.
Note that Cleanup requires BOTH: expired age AND state mismatch.
12 tests covering stale removal, preservation of valid entries, custom maxAge, selective removal, permissionless access, and edge cases.