feat(editor): allow setting of schema attribute #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line-o
force-pushed
the
feat/editor-scheme
branch
from
80bdb42 to
54ab081
Compare
line-o
changed the title
|
@wolfgangmm please have a look if that is all that is needed. Are there tests I need to add? |
windauer
approved these changes
Jul 14, 2025
DrRataplan
reviewed
Aug 27, 2025
refs #60 adding ```json { "features": { "schema": "url/to/myschema.json" } } ``` will add the schema attribute to the jinn-tap element and load it.
DrRataplan
force-pushed
the
feat/editor-scheme
branch
from
54ab081 to
461e988
Compare
DrRataplan
approved these changes
Aug 27, 2025
|
@DrRataplan let's move on and merge, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #60
adding
{ "features": { "schema": "url/to/myschema.json" } }will add the schema attribute to the jinn-tap element and load it.