Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/update-geolite-database.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
branch:
description: "Target branch against which to create PR"
required: false
default: "master"
default: "release-ulmo"

env:
MAXMIND_URL: "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=${{ secrets.MAXMIND_LICENSE_KEY }}&suffix=tar.gz"
Expand Down Expand Up @@ -69,23 +69,23 @@ jobs:
- name: Create a branch, commit the code and make a PR
id: create-pr
run: |
BRANCH="${{ github.actor }}/geoip2-bot-update-country-database-$(echo "${{ github.sha }}" | cut -c 1-7)"
git checkout -b $BRANCH
BRANCH="${{ github.actor }}/geoip2-bot-update-country-database-${{ github.run_id }}"
git checkout -b "$BRANCH"
git add .
git status
git commit -m "chore: geoip2: update maxmind geolite country database"
git push --set-upstream origin $BRANCH
git push --set-upstream origin "$BRANCH"
PR_URL=$(gh pr create \
--title "Update GeoLite Database" \
--body "PR generated by workflow `${{ github.workflow }}` on behalf of @${{ github.actor }}." \
--head $BRANCH \
--base 'master' \
--reviewer 'feanil' \
--head "$BRANCH" \
--base 'release-ulmo' \
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch input parameter is defined for workflow_dispatch but is never used. The base branch for PR creation is hardcoded to 'release-ulmo' on line 82 instead of using ${{ inputs.branch }}. This makes the workflow_dispatch input ineffective.

Consider changing line 82 to use the input parameter:

--base '${{ inputs.branch || 'release-ulmo' }}'

This would allow manual workflow runs to specify a different target branch while defaulting to 'release-ulmo' for scheduled runs.

Copilot uses AI. Check for mistakes.
--reviewer 'edx/orbi-bom' \
| grep -o 'https://github.com/.*/pull/[0-9]*')
echo "PR Created: ${PR_URL}"
echo "pull-request-url=$PR_URL" >> $GITHUB_OUTPUT
env:
GH_TOKEN: ${{ github.token }}
GH_TOKEN: ${{ secrets.GH_PAT_WITH_ORG }}

- name: Job summary
run: |
Expand Down
Binary file modified common/static/data/geoip/GeoLite2-Country.mmdb
Binary file not shown.
Loading