Skip to content

Update GeoLite Database #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktyagiapphelix2u wants to merge 4 commits into
base: release-ulmo
Choose a base branch
from
Open

Update GeoLite Database #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c73c01b
fix: update geolite workflow
ktyagiapphelix2u Nov 19, 2025
0842fac
fix: update geolite workflow
ktyagiapphelix2u Nov 21, 2025
a292683
fix: Update branch naming convention for PR creation
ktyagiapphelix2u Nov 21, 2025
a2975d8
chore: geoip2: update maxmind geolite country database
ktyagiapphelix2u Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/update-geolite-database.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
branch:
description: "Target branch against which to create PR"
required: false
default: "master"
default: "release-ulmo"

env:
MAXMIND_URL: "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=${{ secrets.MAXMIND_LICENSE_KEY }}&suffix=tar.gz"
Expand Down Expand Up @@ -69,23 +69,23 @@ jobs:
- name: Create a branch, commit the code and make a PR
id: create-pr
run: |
BRANCH="${{ github.actor }}/geoip2-bot-update-country-database-$(echo "${{ github.sha }}" | cut -c 1-7)"
git checkout -b $BRANCH
BRANCH="${{ github.actor }}/geoip2-bot-update-country-database-${{ github.run_id }}"
git checkout -b "$BRANCH"
git add .
git status
git commit -m "chore: geoip2: update maxmind geolite country database"
git push --set-upstream origin $BRANCH
git push --set-upstream origin "$BRANCH"
PR_URL=$(gh pr create \
--title "Update GeoLite Database" \
--body "PR generated by workflow `${{ github.workflow }}` on behalf of @${{ github.actor }}." \
--head $BRANCH \
--base 'master' \
--reviewer 'feanil' \
--head "$BRANCH" \
--base 'release-ulmo' \
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --base flag is hardcoded to 'release-ulmo' but should use the workflow input parameter ${{ inputs.branch }} instead. This makes the branch input parameter (lines 8-11) non-functional.

Change to:

--base '${{ inputs.branch }}' \
Suggested change
--base 'release-ulmo' \
--base '${{ inputs.branch }}' \

Copilot uses AI. Check for mistakes.
--reviewer 'edx/orbi-bom' \
| grep -o 'https://github.com/.*/pull/[0-9]*')
echo "PR Created: ${PR_URL}"
echo "pull-request-url=$PR_URL" >> $GITHUB_OUTPUT
env:
GH_TOKEN: ${{ github.token }}
GH_TOKEN: ${{ secrets.GH_PAT_WITH_ORG }}

- name: Job summary
run: |
Expand Down
Binary file modified common/static/data/geoip/GeoLite2-Country.mmdb
View file
Open in desktop
Binary file not shown.
Loading