Fixed bug with read-until. #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please add a comment that describes the problem that your change fixes. 2015-07-24 16:36 GMT+02:00 Michael Malis [email protected]:
|
The KMP algorithm works by building a table which keeps track of which characters in the search string can be skipped when a mismatch occurs. This information is supposed to be maintained in the index of the mismatch. Read-until had previously built the table incorrectly and placed that information in the wrong place.
Author
|
I added that information to the commit. |
Member
|
That causes a problem with Index 3 out of bounds for (SIMPLE-VECTOR 3), should be nonnegative and <3. |
When one of the strings passed to mismatch is a proper prefix of the other, mismatch will return the last index tested in the first string plus one. This means that when the first string is a proper prefix of the second string mismatch will return the length of the first string. To avoid this case, just test that the index of the mismatch is less than the length of the string.
Author
|
Thanks @stassats. The source of that problem is a weird edge case with |
Contributor
|
@malisper are you still interested in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#106