This patch includes: #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweetsurbhi88
commented
Nov 21, 2025
Sweetsurbhi88
commented
- Device State: CLEAN, DIRTY, SCRUB, BUSY
- DeviceStateUpdate RPC
- DeviceChanged Event
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bleggett
reviewed
Nov 21, 2025
protect/control/v1/control.proto
Outdated
| } | ||
|
|
||
| message DeviceChangedEvent { | ||
| protect.common.v1.DeviceReferenceSpec device = 1; |
Collaborator
There was a problem hiding this comment.
Suggested change
| protect.common.v1.DeviceReferenceSpec device = 1; | |
| DeviceReferenceSpec device = 1; |
bleggett
reviewed
Nov 21, 2025
protect/control/v1/control.proto
Outdated
|
|
||
| message DeviceStateRequest { | ||
| string name = 1; | ||
| protect.common.v1.PciDevice state = 2; |
Collaborator
There was a problem hiding this comment.
Suggested change
| protect.common.v1.PciDevice state = 2; | |
| PciDevice state = 2; |
Sweetsurbhi88
force-pushed
the
surbhi/device_lifecycle
branch
3 times, most recently
from
1ae7caa to
54752dc
Compare
1. Device State: CLEAN, DIRTY, SCRUB, BUSY 2. DeviceStateUpdate RPC 3. DeviceChanged Event Signed-off-by: Surbhi Kakarya <[email protected]>
Signed-off-by: Surbhi Kakarya <[email protected]>
Signed-off-by: Surbhi Kakarya <[email protected]>
Sweetsurbhi88
force-pushed
the
surbhi/device_lifecycle
branch
from
a203314 to
8f8a16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.