Skip to content

Conversation

@marcosbento
Copy link
Contributor

Description

An attempt to modernize the code base, by deprecating the "old style" NonCopyable in favour of explicitly deleting copy ctor/copy assignment operator.

This follows the advice of the CppCoreGuidelines, which states = delete is preferred -- see the discussion isocpp/CppCoreGuidelines#1354 (comment).

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.75%. Comparing base (1baad52) to head (cd17fa2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #79   +/-   ##
========================================
  Coverage    77.75%   77.75%           
========================================
  Files           97       97           
  Lines         4932     4932           
  Branches       445      445           
========================================
  Hits          3835     3835           
  Misses        1097     1097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ChrisspyB ChrisspyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChrisspyB ChrisspyB merged commit c8bf310 into develop Dec 16, 2025
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants