Add memory layout relayout functions#392
Open
wdeconinck wants to merge 24 commits into
Open
Conversation
7507393 to
9df75fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several significant improvements and additions to the build system, device abstraction layer, and testing infrastructure. The main changes are the addition of new device property abstractions for the dummy backend, integration of new relayout utilities, and the introduction of a comprehensive benchmarking executable and smoke tests for relayout functionality.
Relayout Utilities Integration:
relayout.cc,relayout.h,relayout_on_host.cc,relayout_on_device.hic) to the build system insrc/atlas/CMakeLists.txt, improving support for data layout transformations on both host and device. [1] [2]Benchmarking and Testing Infrastructure:
atlas-benchmark-relayoutand an extensive set of smoke tests to cover various relayout scenarios, including rank-2/3/4 data, loop order variants, memcpy toggles, and device execution. This enhances test coverage and performance benchmarking capabilities.Configuration Macros:
defines.h.into ensure bounds checking macros are only defined if not already present, avoiding redefinition and improving configurability.Device Abstraction and Runtime Enhancements:
dummyDeviceProp_tstruct inhic_dummy_runtime.hto represent device properties for the dummy backend, and registered new dummy device functions such asGetDeviceandGetDeviceProperties. [1] [2]DeviceProp_tinhic_runtime.hto be backend-specific, supporting CUDA, HIP, and Dummy backends. Also registered new device-related functions in the HIC interface. [1] [2]Contributor Declaration
By opening this pull request, I affirm the following:
💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-392