Skip to content

use dynamic runtime in plugins #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DenisBiryukov91
Copy link
Contributor

@DenisBiryukov91 DenisBiryukov91 commented Jun 24, 2025

  • Pass dynamic runtime to plugins instead of statically typed Runtime to reduce the probability of conflicts due to unstable rust ABI.
  • Make Compatibility struct ABI-stable.

Resolves #1957
Resolves #1745

Copy link

PR missing one of the required labels: {'documentation', 'breaking-change', 'bug', 'new feature', 'internal', 'dependencies', 'enhancement'}

@DenisBiryukov91 DenisBiryukov91 added bug Something isn't working enhancement Existing things could work better labels Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 71.16564% with 94 lines in your changes missing coverage. Please review.

Project coverage is 71.09%. Comparing base (6f9cfa0) to head (210c6d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugins/zenoh-plugin-trait/src/compatibility.rs 0.00% 26 Missing ⚠️
zenoh/src/net/runtime/adminspace.rs 0.00% 12 Missing ⚠️
plugins/zenoh-plugin-example/src/lib.rs 0.00% 7 Missing ⚠️
plugins/zenoh-plugin-rest/src/lib.rs 0.00% 6 Missing ⚠️
plugins/zenoh-plugin-storage-manager/src/lib.rs 45.45% 6 Missing ⚠️
zenoh/src/net/runtime/mod.rs 96.61% 6 Missing ⚠️
...s/zenoh-plugin-trait/src/manager/dynamic_plugin.rs 0.00% 5 Missing ⚠️
plugins/zenoh-backend-example/src/lib.rs 0.00% 4 Missing ⚠️
...h-plugin-storage-manager/src/memory_backend/mod.rs 0.00% 4 Missing ⚠️
...plugin-storage-manager/src/storages_mgt/service.rs 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
- Coverage   71.16%   71.09%   -0.08%     
==========================================
  Files         367      367              
  Lines       61866    61830      -36     
==========================================
- Hits        44030    43961      -69     
- Misses      17836    17869      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DenisBiryukov91 DenisBiryukov91 requested a review from milyin June 25, 2025 15:34
@DenisBiryukov91 DenisBiryukov91 marked this pull request as ready for review June 25, 2025 15:34
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be merged before other plugins are updated accodingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin compatibility checking uses non-ABI-stable types plugin incompatibility is not always detected
2 participants