Fix Session::close timeout while client attempts to reconnect
#2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'bug', 'dependencies', 'internal', 'new feature', 'enhancement', 'documentation'} |
wyfo
approved these changes
Jun 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 71.03% 70.98% -0.05%
==========================================
Files 367 367
Lines 61866 61869 +3
==========================================
- Hits 43944 43917 -27
- Misses 17922 17952 +30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
runtime.start_client()can block depending on status of endpoint and its protocol. This blocking behavior was causing the session to timeout in certain scenarios. This PR fixes this issue by including the call toruntime.start_client()into theselect!on the cancellation token.