Skip to content

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Jun 12, 2025

Fix #1942

I keep the string type for backward compatibility.

Copy link

PR missing one of the required labels: {'new feature', 'documentation', 'breaking-change', 'enhancement', 'internal', 'dependencies', 'bug'}

@evshary evshary added the bug Something isn't working label Jun 12, 2025
@evshary evshary requested a review from kydos June 12, 2025 05:52
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.78%. Comparing base (e8663bd) to head (980acbc).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
plugins/zenoh-backend-traits/src/config.rs 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
- Coverage   70.88%   70.78%   -0.11%     
==========================================
  Files         365      365              
  Lines       61666    61670       +4     
==========================================
- Hits        43713    43654      -59     
- Misses      17953    18016      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OlivierHecart OlivierHecart changed the title Able to accept boolean for the complete in storage_manager Accept a boolean value for the complete field of storage_manager config Jul 9, 2025
@OlivierHecart OlivierHecart merged commit 5dd7caf into eclipse-zenoh:main Jul 9, 2025
19 of 20 checks passed
@evshary evshary deleted the fix_bool_storage branch July 10, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage's complete attribute should be a bool not a string
2 participants