Implement From<&ZBytes> for ZBytes
to simplify usage
#1981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we need to use
publisher.put(sample.payload().clone()).wait().unwrap()
because ZBytes can't be transformed into &ZBytes.Initially, we considered implementing the Copy trait, but Copy can't be implemented in Vec, which is used in
SingleOrVec
.If we implement
From<&ZBytes> for ZBytes
, thensample.payload()
(&ZBytes) can be transformed into ZBytes implicitly, and it simplifies the usage.The downside might be that users aren't aware of the implicit clone, but it should be okay when the clone here is cheap.