Open
Conversation
a029ad8 to
977264d
Compare
Member
BjoernAtBosch
left a comment
There was a problem hiding this comment.
What about if one wants to test a new base image before releasing it on main?
Author
Then there are two ways.
I have tested both of these mechanisms, see https://github.com/erikbosch/devcontainer-base-images/pkgs/container/devcontainer-base-images%2Fbase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not need builds from Pull Requests to be uploaded to ghcr. By removing builds from PRs we solve the problem that PRs originating from a fork cannot upload images to ghcr.
Fixes #70
Replaces #69
Fixes also some CI warnings and improves dash printout
Tested that pusihing to main still creates ghcr image at https://github.com/erikbosch/devcontainer-base-images/pkgs/container/devcontainer-base-images%2Fbase