Conversation
Mission and Vision initially added
add image
data model added
|
Please fix the issues before the review, thx 
|
Update linting
logo is under development
blank lines removed
corrected hyperlink format
|
@stephanbcbauer : issues should be fixed |
|
@eclipse-tractusx/automotive-tractusx-committers i am not available for the next days, please support here to merge the changes. They are relevant for Release 25.12 Thx |
…Architecture, authentication, data exchange flow - review needed The text blocks and mermaid diagrams are created by Claude Sonnet 4.6 AI. The sources were the adption view file, the simplified architecture graphic (approved by review) and two tractus links that the AI analyzed: https://eclipse-tractusx.github.io/docs-kits/kits/industry-core-kit/software-development-view/notifications https://eclipse-tractusx.github.io/docs-kits/kits/industry-core-kit/architecture-view
| participant P_EDC as Provider EDC | ||
| participant P_App as Provider Application | ||
|
|
||
| C_App->>C_EDC: Initiate catalog request (BPNL of provider) |
There was a problem hiding this comment.
| C_App->>C_EDC: Initiate catalog request (BPNL of provider) | |
| C_App->>C_EDC: Initiate catalog request (DID of provider) |
| P_EDC->>P_EDC: Verify VC and evaluate access policy | ||
| P_EDC-->>C_EDC: Return catalog with available assets | ||
|
|
||
| C_EDC->>P_EDC: DSP Contract Negotiation (presents VC + framework credential) |
There was a problem hiding this comment.
| C_EDC->>P_EDC: DSP Contract Negotiation (presents VC + framework credential) | |
| C_APP->>C_EDC: Initiate contract negotiation on selected contract offer | |
| C_EDC->>P_EDC: DSP Contract Negotiation (presents VC + framework credential) |
|
|
||
| C_EDC->>P_EDC: DSP Contract Negotiation (presents VC + framework credential) | ||
| P_EDC->>P_EDC: Verify VC and evaluate contract policy | ||
| P_EDC-->>C_EDC: Contract Agreement + Dataplane Endpoint |
There was a problem hiding this comment.
| P_EDC-->>C_EDC: Contract Agreement + Dataplane Endpoint | |
| P_EDC-->>C_EDC: Contract Agreement | |
| C_EDC-->>C_APP: Notify on contract agreement |
| P_EDC->>P_EDC: Verify VC and evaluate contract policy | ||
| P_EDC-->>C_EDC: Contract Agreement + Dataplane Endpoint | ||
|
|
||
| C_EDC->>P_EDC: DSP Transfer Request |
There was a problem hiding this comment.
| C_EDC->>P_EDC: DSP Transfer Request | |
| C_APP->>C_EDC: Initiate Transfer Request | |
| C_EDC->>P_EDC: DSP Transfer Request |
| P_EDC-->>C_EDC: Contract Agreement + Dataplane Endpoint | ||
|
|
||
| C_EDC->>P_EDC: DSP Transfer Request | ||
| P_EDC-->>C_EDC: Transfer started (dataplane endpoint active) |
There was a problem hiding this comment.
| P_EDC-->>C_EDC: Transfer started (dataplane endpoint active) | |
| P_EDC-->>C_EDC: Transfer started (Data Address) | |
| C_EDC-->>C_APP: Forward contact information to app |
| C_App->>C_EDC: Send notification payload | ||
| C_EDC->>P_EDC: HTTP POST to dataplane endpoint (notification JSON) | ||
| P_EDC->>P_App: Forward notification to backend |
There was a problem hiding this comment.
| C_App->>C_EDC: Send notification payload | |
| C_EDC->>P_EDC: HTTP POST to dataplane endpoint (notification JSON) | |
| P_EDC->>P_App: Forward notification to backend | |
| C_App->>P_EDC_DP Send notification payload | |
| P_EDC_DP->>P_App: Forward notification to backend |
With P_EDC_DP being the dataplane of the provider
Alternatively
| C_App->>C_EDC: Send notification payload | |
| C_EDC->>P_EDC: HTTP POST to dataplane endpoint (notification JSON) | |
| P_EDC->>P_App: Forward notification to backend | |
| C_App->>P_App Send notification payload |
| I_App->>I_CP: 1. Configure Endpoint and Policies | ||
|
|
||
| I_App->>I_CP: 2. Get Authorization / Initiate catalog request | ||
| I_CP->>S_CP: DCP and DSP - Catalog Request + Contract Negotiation |
There was a problem hiding this comment.
| I_CP->>S_CP: DCP and DSP - Catalog Request + Contract Negotiation | |
| I_CP->>S_CP: DSP - Catalog Request + Contract Negotiation |
|
|
||
| The following diagram shows the full sequence for one complete CBAM request-response cycle: | ||
|
|
||
| ```mermaid |
There was a problem hiding this comment.
This sequence diagram requires substantially rework. I suggest, that you concentrate on the interactions between the CBAM-Apps for now and add something with the full dataspace interaction later. Why is it so important for you to show such details? Is this really interesting to repeat what is described in other sources?
There was a problem hiding this comment.
Thank you for again reviewing the file and pointing out what is relevant now and what later.
Important to me is to achieve the minimum level of documentation required to publish this use case as first idea to be discussed. I was told, that also for MVP a development view file is needed. However, I did not find sufficient guidance on the level of detail for this early stage MVP. If the technical details do not matter, then I do not understand why a development view file is needed at all.
Take away:
- from development view I will delete the sections about authentication and data transfer as these are simply wrong. Corrected chapters will have to be added at a later stage.
- The architecture picture will be simplified and any mention about data plane will be deleted. The mention of EDC control plane will be reduced to EDC only. DCP and DSP will be reduced to DSP.
| participant Storage | ||
|
|
||
| Provider->>Connector: Offer data asset | ||
| Connector->>Connector: Register asset |
There was a problem hiding this comment.
HI @johannes-wunderlich , unfortunately, the generated stuff is not correct. And I have not found your references to give wrong guidance. I suggest, that you mention tghat you follow connectivity and industry core principle to initiate the CBAM protocol but then restrict your descriptions on your protocol and leave out all connector interactions and central service interactions. The picture is on a detail level that makes no sense and adds nothing to your use case. And in the details it is too wrong to just fix it in five minutes.
…ta exchange flow, added architecture high level description according to LGBlaumeiser
lgblaumeiser
left a comment
lgblaumeiser
left a comment
There was a problem hiding this comment.
Obviously, some of the pictures are obsolete now. I recommend to remove them, as they are of no value, namely cbam-architecture-alternative.drawio.svg and cbam-architecture.svg. They are not referenced in any .md file. Please remove them prior to merging the PR
I agree on removing the old images. |
There was a problem hiding this comment.
@lgblaumeiser why to remove the dataplane?
This is how it is working now. If it changes in the future, it shall be updated in the future.
There was a problem hiding this comment.
I did not complain on that picture :-). It might change, but that is future
There was a problem hiding this comment.
I did saw it with missing data then,.
There was a problem hiding this comment.
I restored the original architecture picture as shown above which is now described in the development view.
|
I am still having this conflicts |
|
I've been trying to delete the unused images since Monday. However, the delete command isn't working for me. |
matbmoser
left a comment
matbmoser
left a comment
There was a problem hiding this comment.
Since I have done the logo I need to add the copyright from my company.
There was a problem hiding this comment.
I did saw it with missing data then,.
lol |
|
@Jarosch-Mitko would it be fine to add it like it was before the diagram? right now I see it like this: and should be like this: 
so we are also concise with what is happening and the interactions between systems. I commented to Lars that if we also abstract too much it is then not very clear what interacts with what. |
…e.drawio.svg Delete outdated file
…e.drawio.svg.license Delete outdated file
delete outdated file
delete outdated file
Description
This PR covers the first version of the CBAM KIT, adressing the Catena-X solution for the Carbon border adjustment mechanism. It contains a descrition of the CBAM process and the initial data model for the exchange of data between the importer/declarant and supplier.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: