-
Notifications
You must be signed in to change notification settings - Fork 873
Do not analyze when stack overflow has occured #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Frédéric Desbiens <[email protected]>
Added workflow permissions.
Signed-off-by: Frédéric Desbiens <[email protected]>
Updated all actions to their latest release.
Fixed code coverage artefacts upload
Added condition to "Coverage Report Name". Corrected formatting.
Fixed code coverage report download step in deploy_code_coverage.
hank you for this contribution! @gzzi! Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record. Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org. Be sure to use the same email address when you register for the account that you intend to use on Git commit records. Here is the link to sign the ECA: |
I have signed just now. |
I confirm the ECA passes now, @gzzi. I will merge if @billlamiework's review is positive. |
I had the same issue as described in #460. A stack overflow lead to the thread block in a (almost?) forever loop in
_tx_thread_stack_analyze
.The way
_tx_thread_stack_analyze
is implemented doesn't work iftx_thread_stack_highest_ptr
already passed overtx_thread_stack_start
as computation is done on unsigned (see below).With this fix, we don't call
_tx_thread_stack_analyze
anymore if the stack is in a bad state.PR checklist