Skip to content

Conversation

gzzi
Copy link

@gzzi gzzi commented Sep 1, 2025

I had the same issue as described in #460. A stack overflow lead to the thread block in a (almost?) forever loop in _tx_thread_stack_analyze.

The way _tx_thread_stack_analyze is implemented doesn't work if tx_thread_stack_highest_ptr already passed over tx_thread_stack_start as computation is done on unsigned (see below).

image

With this fix, we don't call _tx_thread_stack_analyze anymore if the stack is in a bad state.

PR checklist

  • Updated function header with a short description and version number
  • Added test case for bug fix or new feature
  • Validated on real hardware

@fdesbiens fdesbiens changed the base branch from master to dev September 2, 2025 14:51
@fdesbiens
Copy link
Contributor

hank you for this contribution! @gzzi!

Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record.

Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org.

Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

Here is the link to sign the ECA:
https://accounts.eclipse.org/user/login?destination=user/eca

@gzzi
Copy link
Author

gzzi commented Sep 3, 2025

hank you for this contribution! @gzzi!

Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA).

I have signed just now.

@fdesbiens
Copy link
Contributor

I confirm the ECA passes now, @gzzi.

I will merge if @billlamiework's review is positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants