fix(terminal-manager): update active page handling on terminal page deletion #16807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #16758
This PR improves Terminal Manager behavior when
terminal.grouping.modeis set totreeby:Reset Layoutcommand to properly clear and reset the terminal layout.To support this, the PR introduces a small internal flag
isResetingLayoutand helper methodresetViewinterminal-manager-widgetto distinguish between explicit layout resets and user-initiated page deletions, ensuring correctlifecycle handling without changing public APIs.
How to test
Ensure
terminal.grouping.modeis set totreein your preferences.Test 1: Delete the last page
Expected result:
Test 2: Auto-selection after page deletion
Expected result:
Test 3: Reset Layout
Expected result:
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers