Open
Conversation
ltekieli
force-pushed
the
lt_itf_rule_support
branch
3 times, most recently
from
8a6ac2b to
914ec16
Compare
|
The created documentation from the pull request is available at: docu-html |
ltekieli
force-pushed
the
lt_itf_rule_support
branch
from
914ec16 to
f90169f
Compare
pawelrutkaq
requested changes
Mar 6, 2026
| tag = "stream10", | ||
| ) | ||
| use_repo(oci, "centos_stream10", "ubuntu_22_04") | ||
| use_repo(oci, "centos_stream10", "centos_stream10_linux_amd64") |
Contributor
There was a problem hiding this comment.
@odra which image shall be used centos_stream10 or entos_stream10_linux_amd64?
Member
Author
There was a problem hiding this comment.
With new rules_oci both needs to be use_repo'ed, otherwise module system complains, we can still use the generic version.
ltekieli
force-pushed
the
lt_itf_rule_support
branch
2 times, most recently
from
28b936d to
4ec2117
Compare
ltekieli
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix and
nradakovic
as code owners
PiotrKorkus
reviewed
Mar 9, 2026
- Update score_itf to 44c75de and score_bazel_platforms to b72a5c3 in known_good.json and MODULE.bazel overrides - Add explicit bazel_dep on platforms 1.0.0 (required by new config_settings) - Merge the two py_itf_test targets (linux_x86_64, qnx_x86_64) in feature_integration_tests/itf/BUILD into a single 'itf' target that uses config_setting + select() to switch args/data/plugins per platform; keep backward-compatible aliases for the old target names - Upgrade rules_oci from 1.8.0 to 2.2.7; adapt docker images to use oci_load (replacing the removed oci_tarball) and add the platform-specific repo variants
ltekieli
force-pushed
the
lt_itf_rule_support
branch
from
4ec2117 to
1348e8a
Compare
PiotrKorkus
approved these changes
Mar 9, 2026
Contributor
PiotrKorkus
left a comment
PiotrKorkus
left a comment
There was a problem hiding this comment.
testing lgtm,
./score_starter works with updated runfiles init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
known_good.json and MODULE.bazel overrides
feature_integration_tests/itf/BUILD into a single 'itf' target that uses
config_setting + select() to switch args/data/plugins per platform;
keep backward-compatible aliases for the old target names
to use oci_load (replacing the removed oci_tarball) and add the
platform-specific repo variants