persistency/examples: Provide a integration example#247
Open
umaucher wants to merge 2 commits intoeclipse-score:mainfrom
Open
persistency/examples: Provide a integration example#247umaucher wants to merge 2 commits intoeclipse-score:mainfrom
umaucher wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
Show how to integrate score_persistency in a own standalone bazel workspace and showing the usage of the C++ implementation. Remove the previous pseudo code from the README.md and document the new solution instead.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Comment on lines
+56
to
+59
| # only in the intern examle to test the latest local version instead of the latest released one | ||
| local_path_override( | ||
| module_name = "score_persistency", | ||
| path = "../", |
Contributor
There was a problem hiding this comment.
Should this be here?
Contributor
Author
There was a problem hiding this comment.
yes ... it is ment as hint for other modules which want to use persistency that they don't (need) do it
pawelrutkaq
reviewed
Feb 23, 2026
| @@ -0,0 +1,63 @@ | |||
| # ******************************************************************************* | |||
Contributor
There was a problem hiding this comment.
please dont use seperate bazelmod. This example folder once done, will be auto deployed into refernce integration images to showcase persistency
arkjedrz
reviewed
Feb 23, 2026
Contributor
arkjedrz
left a comment
arkjedrz
left a comment
There was a problem hiding this comment.
I'm not 100% convinced to this change, even though I see good things about it.
- An additional example is a good thing. C++ version was missing them. Rust have them in
src/rust/rust_kvs/examplesdirectory - this is due toexamples/being a special directory in Cargo.
Should<root>/examples/be removed, and C++ examples moved tosrc/cpp/? Or should<root>/examples/reworked to contain both C++ and Rust examples? - IMO having a separated workspace doesn't really help with understanding how to integrate, it just increases noise level.
- I didn't read through all the
README.md, but I see a lot of warnings frommarkdownlint- I recommend it for linting Markdown files.
Contributor
As i commented out, this will prohibit usage of exmaples in reference integration. |
Contributor
|
One thing that this does not describe is the Properties (that are needed for Docs-As-Code to generate testlinks). Is this something we want to add here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show how to integrate score_persistency in a own standalone bazel workspace and showing the usage of the C++ implementation. Remove the previous pseudo code from the README.md and document the new solution instead.