log: C++-based backend implementation by arkjedrz · Pull Request #14 · eclipse-score/logging

arkjedrz · 2025-12-29T13:52:39Z

mw_log backend implementation using baselibs.

github-actions · 2025-12-29T13:57:11Z

The created documentation from the pull request is available at: docu-html

github-actions · 2026-01-06T09:18:40Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: ecaa813e-071f-4614-b09c-b6241402de07
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.8 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.10.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 24.772s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

arkjedrz · 2026-01-19T09:09:44Z

Source code is ready, renames to be done.

src/rust/mw_logger/examples/main.rs

pawelrutkaq · 2026-01-07T09:28:11Z

score/mw/log/rust/score_log_bridge/src/adapter.cpp

+        if (logger->IsLogEnabled(current)) {
+            return current;
+        }
+    }


@hoppe-and-dreams dont we have some API to just check it instead of manually resolving it ?

@rmaddikery ?

MODULE.bazel

score/mw/log/rust/score_log_bridge/src/ffi.rs

pawelrutkaq · 2026-01-20T07:41:08Z

score/mw/log/rust/score_log_bridge/src/score_logger.rs

+                if let Some(ref path) = self.config_path {
+                    let path_os_str = path.as_os_str();
+                    if !path_os_str.is_empty() {
+                        unsafe { set_var(KEY, path_os_str) };


add #safety caluse to all unsafe stuff in this pr

What i mean is unsafe inside fn requires // Safety: description why its still safe here

score/mw/log/rust/score_log_bridge/src/score_logger.rs

score/mw/log/rust/score_log_bridge/src/score_logger_writer.rs

score/mw/log/rust/score_log_bridge/src/ffi.rs

vinodreddy-g · 2026-01-22T07:25:51Z

score/mw/log/rust/score_log_bridge/src/adapter.cpp

+
+// Verify configuration.
+#if defined(x86_64_linux) || defined(arm64_qnx)
+static_assert(sizeof(SlotHandle) == 24);


We need a comment why 24 . Since it is based on the struct size after padding.

I rephrased a comment and pasted it both to C++ and Rust files.

vinodreddy-g · 2026-01-22T08:04:47Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+        // Disallow non-ASCII strings.
+        // ASCII characters are single byte in UTF-8.
+        if !value.is_ascii() {
+            panic!("Provided context contains non-ASCII characters: {value}");


Could we write a comment to replace the panic later. We should avoid panics and asserts in release mode code . I think we need to replace them later with a function which can be panic during development and uses the health monitoring api for release modes.

There is low chance that you can do something here, especially complex things. So we shall recheck with cpp but they also call std::terminate in non recoverable errors.

vinodreddy-g · 2026-01-22T08:05:23Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+        // Get recorder and check it's not null.
+        // SAFETY: panics on null recorder.
+        let ptr = unsafe { recorder_get() };
+        assert!(!ptr.is_null());


Same for this assert .

pawelrutkaq · 2026-01-22T08:12:10Z

score/mw/log/rust/score_log_bridge/src/score_logger.rs

+    /// # Safety
+    ///
+    /// Method sets `MW_LOG_CONFIG_FILE` environment variable.
+    /// Setting environment variable is safe only in single-threaded environments.


it shall be written that its safe to call it in main, before any other threads start. Otherwise, no one could ever use it. (i know what is written in Rust doc, but this is really what they mean)

pawelrutkaq · 2026-01-22T08:12:46Z

score/mw/log/rust/score_log_bridge/src/score_logger.rs

+                if let Some(ref path) = self.config_path {
+                    let path_os_str = path.as_os_str();
+                    if !path_os_str.is_empty() {
+                        unsafe { set_var(KEY, path_os_str) };


What i mean is unsafe inside fn requires // Safety: description why its still safe here

pawelrutkaq · 2026-01-22T08:23:54Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+        // Disallow non-ASCII strings.
+        // ASCII characters are single byte in UTF-8.
+        if !value.is_ascii() {
+            panic!("Provided context contains non-ASCII characters: {value}");


There is low chance that you can do something here, especially complex things. So we shall recheck with cpp but they also call std::terminate in non recoverable errors.

pawelrutkaq · 2026-01-22T08:36:14Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+    #[inline]
+    fn write_i8(&mut self, v: &i8, spec: &FormatSpec) -> FmtResult {
+        // SAFETY: FFI calls. Reference is reinterpreted as a pointer of the same type.
+        unsafe {


unsafe shall enclose lowest possible block

pawelrutkaq · 2026-01-22T08:36:45Z

score/mw/log/rust/score_log_bridge/src/ffi.rs

+    #[inline]
+    fn write_str(&mut self, v: &str, _spec: &FormatSpec) -> FmtResult {
+        // Get string as pointer and size.
+        let v_ptr = v.as_ptr() as *const c_char;


`mw_log` backend implementation using `baselibs`.

- Improve `Context`: - Use it consistenly internally - no allocs. - Make use of `From` traits (to and from `&str`). - Check layout on every logger builder. - Cheap and rare operation, no deps to `std::sync` required. - Improve docs and add safety notes. - `LogMessage`: - Merge `ScoreLoggerWriter` and `LogStream` - less layers. - Remove `score_logger_writer.rs`. - Add `#[inline]` where applicable. - Prevent operation in erroneous state (e.g., when null returned). - Less branching. - Move `Send` and `Sync` where actually needed (to `Recorder`). - Improve example.

…_status Merge current score repo status Signed off by: @antonkrivoborodov

* log: C++-based backend implementation `mw_log` backend implementation using `baselibs`. * log: post-review fixes - Improve `Context`: - Use it consistenly internally - no allocs. - Make use of `From` traits (to and from `&str`). - Check layout on every logger builder. - Cheap and rare operation, no deps to `std::sync` required. - Improve docs and add safety notes. - `LogMessage`: - Merge `ScoreLoggerWriter` and `LogStream` - less layers. - Remove `score_logger_writer.rs`. - Add `#[inline]` where applicable. - Prevent operation in erroneous state (e.g., when null returned). - Less branching. - Move `Send` and `Sync` where actually needed (to `Recorder`). - Improve example.

arkjedrz force-pushed the arkjedrz_mw-log branch from 34f6f12 to 235d8c1 Compare December 30, 2025 10:28

arkjedrz requested a review from vinodreddy-g January 5, 2026 09:18

arkjedrz force-pushed the arkjedrz_mw-log branch 2 times, most recently from 93febff to 8ff01eb Compare January 6, 2026 09:17

arkjedrz temporarily deployed to workflow-approval January 6, 2026 09:18 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from 8ff01eb to a7e0958 Compare January 6, 2026 13:43

arkjedrz temporarily deployed to workflow-approval January 6, 2026 13:43 — with GitHub Actions Inactive

arkjedrz marked this pull request as ready for review January 6, 2026 13:53

arkjedrz requested review from antonkri, arsibo and pawelrutkaq as code owners January 6, 2026 13:53

arkjedrz force-pushed the arkjedrz_mw-log branch from a7e0958 to 50fc165 Compare January 7, 2026 10:09

arkjedrz temporarily deployed to workflow-approval January 7, 2026 10:09 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from 50fc165 to cd7528c Compare January 7, 2026 13:41

arkjedrz temporarily deployed to workflow-approval January 7, 2026 13:41 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from cd7528c to 872b1af Compare January 12, 2026 13:14

arkjedrz temporarily deployed to workflow-approval January 12, 2026 13:14 — with GitHub Actions Inactive

arkjedrz self-assigned this Jan 14, 2026

arkjedrz marked this pull request as draft January 15, 2026 07:28

arkjedrz temporarily deployed to workflow-approval January 16, 2026 13:25 — with GitHub Actions Inactive

arkjedrz temporarily deployed to workflow-approval January 19, 2026 08:25 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from b2792db to dde419b Compare January 19, 2026 08:58

arkjedrz temporarily deployed to workflow-approval January 19, 2026 08:58 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from dde419b to 018f7f5 Compare January 19, 2026 09:03

arkjedrz temporarily deployed to workflow-approval January 19, 2026 09:03 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from 018f7f5 to 8b22ae1 Compare January 19, 2026 09:05

arkjedrz temporarily deployed to workflow-approval January 19, 2026 09:05 — with GitHub Actions Inactive

arkjedrz marked this pull request as ready for review January 19, 2026 09:07

arkjedrz force-pushed the arkjedrz_mw-log branch from 8b22ae1 to c1ab28e Compare January 19, 2026 11:02

arkjedrz temporarily deployed to workflow-approval January 19, 2026 11:03 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from c1ab28e to 7f41f28 Compare January 19, 2026 11:41

arkjedrz temporarily deployed to workflow-approval January 19, 2026 11:41 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from 7f41f28 to b950507 Compare January 19, 2026 15:38

arkjedrz temporarily deployed to workflow-approval January 19, 2026 15:38 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from b950507 to 28050b6 Compare January 20, 2026 07:24

arkjedrz temporarily deployed to workflow-approval January 20, 2026 07:25 — with GitHub Actions Inactive

pawelrutkaq requested changes Jan 20, 2026

View reviewed changes

pawelrutkaq mentioned this pull request Jan 20, 2026

Updates CODEOWNERS for datarouter and mw/log directories #29

Merged

10 tasks

arkjedrz temporarily deployed to workflow-approval January 21, 2026 09:54 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log branch from 2e20e41 to 7e0c59d Compare January 21, 2026 09:55

arkjedrz temporarily deployed to workflow-approval January 21, 2026 09:56 — with GitHub Actions Inactive

arkjedrz requested a review from pawelrutkaq January 21, 2026 09:56

vinodreddy-g reviewed Jan 22, 2026

View reviewed changes

pawelrutkaq requested changes Jan 22, 2026

View reviewed changes

arkjedrz added 2 commits January 22, 2026 10:14

log: C++-based backend implementation

7d2ed9d

`mw_log` backend implementation using `baselibs`.

arkjedrz force-pushed the arkjedrz_mw-log branch from 7e0c59d to f37fff3 Compare January 22, 2026 12:51

arkjedrz temporarily deployed to workflow-approval January 22, 2026 12:51 — with GitHub Actions Inactive

arkjedrz requested review from pawelrutkaq and vinodreddy-g January 22, 2026 13:57

pawelrutkaq approved these changes Jan 22, 2026

View reviewed changes

pawelrutkaq merged commit a8d7060 into eclipse-score:main Jan 22, 2026
10 checks passed

arkjedrz deleted the arkjedrz_mw-log branch January 22, 2026 14:07

opajonk pushed a commit to elektrobit-contrib/eclipse-score_logging that referenced this pull request Jan 27, 2026

Merge pull request eclipse-score#14 from oss/ankr_merge_current_score…

ec4ee8b

…_status Merge current score repo status Signed off by: @antonkrivoborodov

Comments

Conversation

arkjedrz commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

arkjedrz commented Jan 19, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arkjedrz commented Dec 29, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading