Skip to content

Comments

Add pre-commit config & upgrade devcontainer#411

Draft
MaximilianSoerenPollak wants to merge 36 commits intoeclipse-score:mainfrom
MaximilianSoerenPollak:MSP_add_pre_commit
Draft

Add pre-commit config & upgrade devcontainer#411
MaximilianSoerenPollak wants to merge 36 commits intoeclipse-score:mainfrom
MaximilianSoerenPollak:MSP_add_pre_commit

Conversation

@MaximilianSoerenPollak
Copy link
Contributor

Upgraded devcontainer from 1.0 -> 1.2
Added basic pre-commit configuration file
Added README instructions

📌 Description

Upgraded devcontainer from 1.0 -> 1.2
Added basic pre-commit configuration file
Added README instructions

This theoretically should work if executed inside the devcontainer, everywhere I tested it, it did.

However I could not get basedpyright to run inside there too for some odd reason ;/ not sure why.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Feb 23, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 6f7c3a8a-da27-40ff-ae7f-b32fc26e0e05
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (68 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (76 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (128 packages loaded, 1673 targets configured)

Analyzing: target //src:license-check (129 packages loaded, 2510 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

Analyzing: target //src:license-check (140 packages loaded, 2576 targets configured)

INFO: Analyzed target //src:license-check (145 packages loaded, 4715 targets configured).
[1 / 1] no actions running
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 21.300s, Critical Path: 2.66s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

{
"name": "eclipse-s-core",
"image": "ghcr.io/eclipse-score/devcontainer:1.0.0",
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this and tell me if you stell need PIPX_BIN_DIR to execute pre-commit?

Suggested change
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/bash_completion.d/add_pipx_to_path",

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works in conjunction with devcontainer/cli. If this works I can add this to the image.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I found a solution, which works in /etc/profile.d/. This took me way too long time

Suggested change
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/profile.d/add_pipx_to_path.sh",

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be taken care of with eclipse-score/devcontainer#98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Draft

Development

Successfully merging this pull request may close these issues.

2 participants