Skip to content

fix: don't use deprecated API in config_parser #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artemsheinacn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't use deprecated API in config_parser #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion score/mw/com/impl/configuration/config_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ auto ParseInstanceSpecifier(const score::json::Object& json_map) -> InstanceSpec
auto string_result = instanceSpecifierJson->second.As<std::string>();
SCORE_LANGUAGE_FUTURECPP_PRECONDITION_PRD_MESSAGE(string_result.has_value(), "Configuration corrupted, check with json schema");
const auto& string_view = string_result.value().get();
const auto instance_specifier_result = InstanceSpecifier::Create(string_view);
const auto instance_specifier_result = InstanceSpecifier::Create(std::string{string_view});
if (!instance_specifier_result.has_value())
{
score::mw::log::LogFatal("lola") << "Invalid InstanceSpecifier.";
Expand Down
Loading