Rust::com Derive macro for CommData#156
Draft
bharatGoswami8 wants to merge 1 commit intoeclipse-score:mainfrom
Draft
Rust::com Derive macro for CommData#156bharatGoswami8 wants to merge 1 commit intoeclipse-score:mainfrom
bharatGoswami8 wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
bharatGoswami8
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
pawelrutkaq
requested changes
Feb 9, 2026
bharatGoswami8
force-pushed
the
rust_com_api_derive_macro_commData
branch
from
719a3c7 to
7524795
Compare
pawelrutkaq
requested changes
Feb 10, 2026
* Implemented derive macro for CommData trait impl
bharatGoswami8
force-pushed
the
rust_com_api_derive_macro_commData
branch
from
7524795 to
14a7f51
Compare
pawelrutkaq
reviewed
Feb 18, 2026
Contributor
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
LGTM, one issues found
| #[derive(Debug, Reloc)] | ||
| #[derive(Debug, CommData)] | ||
| #[repr(C)] | ||
| // No explicit ID provided, so it will be auto-generated as "com_api_gen::Exhaust" |
Contributor
There was a problem hiding this comment.
Rechecked an my bad -all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#155