Restrict access to MemoryResourceProxy in ManagedMemoryResource#52
Open
jorgecasal wants to merge 2 commits intoeclipse-score:mainfrom
Open
Conversation
jorgecasal
requested review from
4og,
LittleHuba,
castler,
hoe-jo,
nradakovic and
ramceb
as code owners
|
The created documentation from the pull request is available at: docu-html |
2 tasks
Contributor
|
Hi @jorgecasal, this change looks great – Thanks! |
jorgecasal
force-pushed
the
feature/issue-94-memory-resource-proxy-visibility
branch
from
be91425 to
aef8f12
Compare
jorgecasal
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
jorgecasal
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
jorgecasal
force-pushed
the
feature/issue-94-memory-resource-proxy-visibility
branch
from
aef8f12 to
3b37e47
Compare
jorgecasal
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
jorgecasal
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
jorgecasal
force-pushed
the
feature/issue-94-memory-resource-proxy-visibility
branch
from
3b37e47 to
aef8f12
Compare
jorgecasal
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
jorgecasal
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
- Restrict MemoryResourceProxy access via private method and friend allocator - Deprecate raw pointer PolymorphicOffsetPtrAllocator constructor - Remove deprecated raw pointer constructor from PolymorphicOffsetPtrAllocator - Update PUML diagrams to reflect new allocator API - Fix allocator test helper to use new ManagedMemoryResource constructor
jorgecasal
force-pushed
the
feature/issue-94-memory-resource-proxy-visibility
branch
from
aef8f12 to
6726d5f
Compare
jorgecasal
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
jorgecasal
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
…ility Signed-off-by: Jorge C. Santos <156771132+jorgecasal@users.noreply.github.com>
jorgecasal
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
jorgecasal
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
Contributor
Author
|
Hi @fbaeuerle, thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the public visibility of
getMemoryResourceProxy()inManagedMemoryResourceand changes thePolymorphicOffsetPtrAllocatorconstructor to acceptManagedMemoryResourceinstead of a proxy pointer. OnlyPolymorphicOffsetPtrAllocatoris allowed to callgetMemoryResourceProxy()via friend class access.resolves #94