BUILD for aarch64 : Suggested changes#100
Draft
rahulthakre29 wants to merge 2 commits intoeclipse-score:mainfrom
Draft
BUILD for aarch64 : Suggested changes#100rahulthakre29 wants to merge 2 commits intoeclipse-score:mainfrom
rahulthakre29 wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
346bf99 to
79047c4
Compare
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
79047c4 to
b45bfdb
Compare
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
b45bfdb to
f8d4bb8
Compare
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
f8d4bb8 to
7c5e445
Compare
rahulthakre29
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
4og
requested changes
Feb 10, 2026
MODULE.bazel
Outdated
| name = "valgrind-deb", | ||
| name = "acl-deb-arm64", | ||
| build = "//third_party/acl:acl-arm64.BUILD", | ||
| urls = ["https://launchpadlibrarian.net/581258948/libacl1-dev_2.3.1-1_arm64.deb"], |
Member
There was a problem hiding this comment.
Let's get it from https://ports.ubuntu.com/pool/main/a/acl/ instead.
Please also update the version for amd64
| @@ -0,0 +1,14 @@ | |||
| cc_library( | |||
Member
There was a problem hiding this comment.
Why is this split to dev and non-dev?
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
ffb641c to
9d7698f
Compare
rahulthakre29
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
rahulthakre29
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
9d7698f to
4446685
Compare
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
4446685 to
c8d2343
Compare
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
rahulthakre29
force-pushed
the
rt/investigating_build_baselib_on_AArch64_Linux
branch
from
c8d2343 to
94efb57
Compare
rahulthakre29
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
4og
requested changes
Feb 19, 2026
Comment on lines
+43
to
+78
| # Platform-aware library aliases for backward compatibility | ||
| alias( | ||
| name = "acl", | ||
| actual = "//third_party/acl:acl", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| alias( | ||
| name = "libcap2", | ||
| actual = "//third_party/libcap2:libcap2", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| alias( | ||
| name = "libcap2-dev", | ||
| actual = "//third_party/libcap2:libcap2", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| alias( | ||
| name = "libseccomp2", | ||
| actual = "//third_party/libseccomp2:libseccomp2", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| alias( | ||
| name = "libseccomp2-dev", | ||
| actual = "//third_party/libseccomp2:libseccomp2", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| alias( | ||
| name = "valgrind", | ||
| actual = "//third_party/valgrind:valgrind", | ||
| visibility = ["//visibility:public"], | ||
| ) |
Member
There was a problem hiding this comment.
There are already aliases and cc_library targets in //third-party/... Let's not have one more indirection
| deps = select({ | ||
| "@platforms//os:qnx": [], | ||
| "//conditions:default": ["//third_party/valgrind"], | ||
| "//conditions:default": ["//:valgrind"], |
Member
There was a problem hiding this comment.
This change is not needed. Having it refer to //third_party/valgrind is perfectly fine. Moreover, by not having this change, we'll avoid change sin our internal codebase.
| ], | ||
| deps = [ | ||
| "//third_party/libseccomp2", | ||
| "//:libseccomp2-dev", |
Member
There was a problem hiding this comment.
Same as in the valgrind case above. Please leave deps to //third_party/... without change. Same applies to all other similar cases in this PR.
Comment on lines
+4
to
+5
| "@platforms//cpu:aarch64": ["lib/aarch64-linux-gnu/libacl.a"], | ||
| "//conditions:default": ["lib/x86_64-linux-gnu/libacl.a"], |
Member
There was a problem hiding this comment.
lib/x86_64-linux-gnu/libacl.ais a symlink in deb archive tousr/lib/x86_64-linux-gnu/libacl.a. I would avoid extra indirection, i.e. keepusr/lib- In case of aarch64, there is no such symlink, so the build will likely to fail, i.e. add
usr/in front
You can validate AArch64 builds locally with bazel build --config=bl-aarch64-linux //score/...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested Changes to build aarch64 on Baselib