Skip to content

Add new getPatternText() method to FilteredItemsSelectionDialog #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025

Conversation

jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Aug 7, 2025

@jjohnstn
Copy link
Contributor Author

jjohnstn commented Aug 7, 2025

This change is required to be able to manage the type name text input in the Open Types dialog which inherits from the FilteredItemsSelectionDialog which holds the text widget and uses it to form search patterns. The user request is for a way to default wildcards between camel case segments when searching for types rather than adding them manually. I added the new method because the pattern control was private and the text was used directly in the code without an opportunity to add the wildcards. It is possible that the preference or option could be moved to platform and then JDT needn't make any changes.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Test Results

 2 477 files   -   301   2 477 suites   - 301   1h 36m 16s ⏱️ - 6m 36s
 7 933 tests ±    0   7 703 ✅  -     1  229 💤 ±  0  1 ❌ +1 
21 684 runs   - 1 656  21 141 ✅  - 1 462  542 💤  - 195  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 22dfd87. ± Comparison against base commit c496bbc.

♻️ This comment has been updated with latest results.

@jjohnstn
Copy link
Contributor Author

@laeubi Any further issues? Can this be merged for M3? If possible, could you assign this to me? Thanks. On the JDT UI side I also am willing to scrap the new preference page for activating this and turn on the feature by default.

@merks
Copy link
Contributor

merks commented Aug 14, 2025

Could you rebase, squash to a single commit, and force push that. I'll keep an eye out and merge this the build finishes.

- add new protected method to FilteredItemsSelectionDialog so that
  JDT UI can modify the output to add defaulted wildcards in camel
  case type names
- bump up org.eclipse.ui.workbench to 3.136.0
- needed for eclipse-jdt/eclipse.jdt.ui#2387
@jjohnstn
Copy link
Contributor Author

@merks Squashed and rebased. Thanks.

@merks
Copy link
Contributor

merks commented Aug 14, 2025

I’ll ignore the heap space failure. Monitoring progress of other platforms.

@merks
Copy link
Contributor

merks commented Aug 14, 2025

Test failure on macOS appears unrelated.

@merks merks merged commit 0539498 into eclipse-platform:master Aug 14, 2025
15 of 18 checks passed
@jjohnstn
Copy link
Contributor Author

Thanks @merks

@jjohnstn jjohnstn deleted the camelcasewildcard branch August 14, 2025 16:01
@merks
Copy link
Contributor

merks commented Aug 14, 2025

What goes around comes around. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants