-
Notifications
You must be signed in to change notification settings - Fork 222
Add new getPatternText() method to FilteredItemsSelectionDialog #3152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jjohnstn
commented
Aug 7, 2025
- add new protected method to FilteredItemsSelectionDialog so that JDT UI can modify the output to add defaulted wildcards in camel case type names
- bump up org.eclipse.ui.workbench to 3.136.0
- needed for Create new preferences option to have Open Type dialog Automatically Search with * between capital letters eclipse-jdt/eclipse.jdt.ui#2387
This change is required to be able to manage the type name text input in the Open Types dialog which inherits from the FilteredItemsSelectionDialog which holds the text widget and uses it to form search patterns. The user request is for a way to default wildcards between camel case segments when searching for types rather than adding them manually. I added the new method because the pattern control was private and the text was used directly in the code without an opportunity to add the wildcards. It is possible that the preference or option could be moved to platform and then JDT needn't make any changes. |
Test Results 2 477 files - 301 2 477 suites - 301 1h 36m 16s ⏱️ - 6m 36s For more details on these failures, see this check. Results for commit 22dfd87. ± Comparison against base commit c496bbc. ♻️ This comment has been updated with latest results. |
.../org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java
Outdated
Show resolved
Hide resolved
@laeubi Any further issues? Can this be merged for M3? If possible, could you assign this to me? Thanks. On the JDT UI side I also am willing to scrap the new preference page for activating this and turn on the feature by default. |
Could you rebase, squash to a single commit, and force push that. I'll keep an eye out and merge this the build finishes. |
- add new protected method to FilteredItemsSelectionDialog so that JDT UI can modify the output to add defaulted wildcards in camel case type names - bump up org.eclipse.ui.workbench to 3.136.0 - needed for eclipse-jdt/eclipse.jdt.ui#2387
ea78059
to
22dfd87
Compare
@merks Squashed and rebased. Thanks. |
I’ll ignore the heap space failure. Monitoring progress of other platforms. |
Test failure on macOS appears unrelated. |
Thanks @merks |
What goes around comes around. 😁 |