Skip to content

WIP: Make DnD consumer monitorAware #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amartya4256
Copy link
Contributor

@amartya4256 amartya4256 commented May 22, 2025

Depends on: eclipse-platform/eclipse.platform.swt#2186

This PR enforces the usage of Rectangle.copyWith and Rectangle.of
while copying a rectangle from an existing rectangle and creating a
rectangle from a Point making sure the internal state of the source
resources are copied to the new resource.

contributes to eclipse-platform/eclipse.platform.swt#62 and eclipse-platform/eclipse.platform.swt#128

Copy link
Contributor

github-actions bot commented May 22, 2025

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 32m 55s ⏱️ - 6m 4s
 7 928 tests ±0   7 700 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 337 runs  ±0  22 591 ✅ ±0  746 💤 ±0  0 ❌ ±0 

Results for commit b9efa80. ± Comparison against base commit ca63f41.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Jun 18, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF

⚠️ 🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as additional commit.

Git patch
From c89c35664edafc7bab1318917685a326d9825768 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 18 Jun 2025 12:35:57 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF
index 619bce77e8..7cda4cc33f 100644
--- a/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.addons.swt;singleton:=true
-Bundle-Version: 1.5.700.qualifier
+Bundle-Version: 1.5.800.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

This commit enforces the usage of Rectangle.clone and Rectangle.of
while copying a rectangle from an existing rectangle and creating a
rectangle from a Point making sure the internal state of the source
resources are copied to the new resource.

contributes to
eclipse-platform/eclipse.platform.swt#62 and
eclipse-platform/eclipse.platform.swt#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and Drop Region moves with a different scale as compared to the cursor between 2 monitors
2 participants