Convert FileDialog#setFilterExtensions to varargs #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As it's semantically coupled with setFilterNames it would be good if they use the same style. |
Test Results 539 files ±0 539 suites ±0 33m 2s ⏱️ + 3m 26s For more details on these failures, see this check. Results for commit 86f1841. ± Comparison against base commit e2cbda9. ♻️ This comment has been updated with latest results. |
Will do, I just wanted to see what the general feedback was before doing to much changes. |
|
It's a fine change IMO. |
Nicer to use for end user and API compliant. If this change is integrated we must update the usage of this method in platform to avoid compiler warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicer to use for end user and API compliant. If this change is integrated we must update the usage of this method in platform to avoid compiler warnings.