Ensure DrawImage deals with scenario ImageData not linearly scaled #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjose696
force-pushed
the
arunjose696/313/FixDrawImageScaling
branch
2 times, most recently
from
36ccead to
45cd163
Compare
akoch-yatta
reviewed
Jun 23, 2025
Comment on lines
1029
to
1032
| Rectangle scaledBounds = image.getBounds(scaledImageZoom); | ||
| Rectangle unScaledBound = image.getBounds(); | ||
| float scalingFactor = (float) scaledBounds.height / unScaledBound.height; | ||
| Rectangle src = DPIUtil.scaleUp(drawable, new Rectangle(srcX, srcY, srcWidth, srcHeight),(int) (scalingFactor * 100)); |
There was a problem hiding this comment.
I thought about this a bit. Isn't it possible to do the check regarding getBounds in the calling place and then pass the "correct" scaledImageZoom, so the implementation in here can stay as is and the change is in the calling place in GC?
There was a problem hiding this comment.
The earlier approach was to use scaledImageZoom as before to obtain Image.win32_getHandle(), using the "correct" zoom level only for calculating the bounds. , but taking another look it would not make much difference if we get handles at either of these. I have moved this logic to the calling site when the scaledImageZoom is calculated
arunjose696
force-pushed
the
arunjose696/313/FixDrawImageScaling
branch
3 times, most recently
from
573ed10 to
7ede441
Compare
This change makes sure DrawImage handles the scenario where ImageData may not be linearly scaled across zooms.
arunjose696
force-pushed
the
arunjose696/313/FixDrawImageScaling
branch
from
7ede441 to
9b0b4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure DrawImage handles the scenario where ImageData may not be linearly scaled across zooms.