Skip to content

Conversation

Nocccer
Copy link

@Nocccer Nocccer commented Mar 15, 2025

Description

To avoid data races that occured in #703, a copy is now returned by the memstore instead a pointer to the packet.

  • Extend the ControlPacket interface with Copy() ControlPacket function.
  • Add tests to check if the copy does not share any pointer with the original packet.
  • Use the Copy() function in the memstore to return a copy.
  • Test changes against the test from Data race while reconnecting #703 that triggered the race condition.

Note: This is my private github account, so don't get confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant