-
Notifications
You must be signed in to change notification settings - Fork 163
Switched to parent 2.0.0-M1 #25843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Switched to parent 2.0.0-M1 #25843
Conversation
Signed-off-by: David Matějček <[email protected]>
Why it would be blocking? M-releases were and are continuously used here. glassfish/nucleus/parent/pom.xml Line 117 in 92d03cf
glassfish/nucleus/parent/pom.xml Line 143 in 92d03cf
glassfish/nucleus/parent/pom.xml Lines 1148 to 1151 in 92d03cf
Why parent would be special? |
|
@pzygielo bad practice. Obviously these should be updated before the final 8.0.0 release too. |
then, there are also Line 189 in 92d03cf
glassfish/appserver/tests/tck/pages/pom.xml Lines 70 to 75 in 92d03cf
glassfish/appserver/tests/tck/pages/pom.xml Lines 77 to 82 in 92d03cf
|
- parent had higher priority and plugin ignored our configuration and published artifacts despite we forbid it. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
|
and perhaps Line 130 in 92d03cf
|
This PR was made to test if changes in parent are good for us as this is probably the most complicated child.
TODO: Blocked until we have parent 2.0.0 (not just milestone).
Latest info: Parent team decided to use the new staging plugin before the release of parent 2.0.0, so I guess this PR will have to wait for M2 and then for the final release. We don't need staging here as we follow the convention of the Maven Central and we also already deploy snapshots to Maven Central, so anyone can refer a snapshot dependency temporarily/experimentally.
Result of https://ci.eclipse.org/glassfish/view/Release/job/glassfish-release/34/ - Parent overridden our configuration and CI published it, unfortunately. I wrote an email to Maven Central Support if it is possible to revert it. I committed changes here to fix it for next executions. Be more careful than I was ...