Skip to content

Conversation

@jonahgraham
Copy link
Member

This is the corresponding CDT LSP PR to CDT's eclipse-cdt/cdt#1394

Part of #537

@jonahgraham
Copy link
Member Author

The license check is about a dependency we pull from platform (lucene).

Therefore I declare this ready to go.

@jonahgraham jonahgraham merged commit 4c780c9 into main Dec 2, 2025
4 of 6 checks passed
@jonahgraham jonahgraham deleted the 3.4-prep branch December 2, 2025 02:05
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?>
<target name="cdt" sequenceNumber="153">
<target name="cdt" sequenceNumber="171">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this just a random number,or where Do you get this from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They say it is not needed anymore, so we can remove it and reduce the scope of the changes needed to update target platform in the future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this just a random number,or where Do you get this from?

It used to be used by PDE to know if the file changed. It used to be incremented by tooling on each edit, but I have also heard what @ruspl-afed said - PRs welcome to remove it from here and CDT's one. I'll try to remember to remove on my next update if no one has before then.

@jonahgraham jonahgraham added this to the 3.4.0 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants