Skip to content

Don't set focus on preference page creation #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitind wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't set focus on preference page creation #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion org.eclipse.buildship.ui/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11"/>
Copy link
Copy Markdown
Contributor

@donat donat Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent here with not specifying the version was to allow the active target definition to select the Java version. That way, we can always select the lowest required java version for a given Eclipse platform version.

❌ This change should not be part of this PR.

<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
<classpathentry kind="src" path="src/main/java"/>
<classpathentry kind="src" path="src/main/resources"/>
Expand Down
3 changes: 1 addition & 2 deletions .../src/main/java/org/eclipse/buildship/ui/internal/util/widget/GradleDistributionGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2023 Gradle Inc. and others
* Copyright (c) 2023, 2025 Gradle Inc. and others
*
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -214,7 +214,6 @@ private void updateSelectedState(Button selectedRadioButton, List<Button> allRad
for (Button radioButton : allRadioButtons) {
if (radioButton.equals(selectedRadioButton)) {
radioButton.setSelection(true);
radioButton.setFocus();
Copy link
Copy Markdown
Contributor

@donat donat Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

} else {
radioButton.setSelection(false);
}
Expand Down