Skip to content

Approach for submission of raw data#92

Open
DunklesArchipel wants to merge 28 commits intoechemdb:mainfrom
DunklesArchipel:raw-submission
Open

Approach for submission of raw data#92
DunklesArchipel wants to merge 28 commits intoechemdb:mainfrom
DunklesArchipel:raw-submission

Conversation

@DunklesArchipel
Copy link
Member

@DunklesArchipel DunklesArchipel commented Aug 29, 2025

  • Added a news file.
  • The following checks must be adapted
  • Add a schema for raw data
  • create a converter to include in pixi
  • create a common folder for bib files
    • Acces bib data and add as bibdata to the YAML
    • Add option to bibliography in svgdigitizer to specify the path of bib files
  • remove unnecessary columns
  • Add and fix test
  • Fix news
  • Change raw_data folder into a different name that does not suggest that the data is straight from the instrument: source_data or provided_data

Depends on echemdb/unitpackage#127

For other PRs

  • determine identifiers for CVs which are not labeled in the original publication (black curves in engstfeld 4b)
  • import from mpt files

Literature Addition Checklist

For contributors and reviewers alike.

  • Name PR Add literature_identifier

Filename

  • Words and identifiers in the filenames must be lowercase.
  • The filename must be of type <Name>_<Year>_<FirstWordFirstPage>_<FirstPageNumber>_<fxy>_<Identifier>, where x is the figure number and y the subfigure label, i.e., 2b. For supporting information figures, use sfxy instead.
  • The figure number must match that of the figure in the article.

Bib file

  • The identifier must be identical with the filename as well as the citationKey in the YAML.
  • Remove typos (or unwanted whitespace), specifically in the title such as Pt (111) to Pt(111).

SVG

  • The curve label should be short and unambiguous?
  • Figure label should be of type Figure: xy (not Figure: fxy).
  • The figure label must be identical to that in the article.
  • Comments should be complete sentences ending with a period.
  • A tags text label should be included in the SVG indicating the type of measurement (BCV, ORR, COOR, etc).
  • The units on the axis should be identical to those in the figure.
  • Considered a possible scaling factor?

YAML

  • The identifier must be identical to that in the filename.
  • Comments should be complete sentences ending with a period.

@DunklesArchipel DunklesArchipel marked this pull request as ready for review February 2, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant