feat: make this plugin can run on non-maven project (wihtout pom.xml)#56
feat: make this plugin can run on non-maven project (wihtout pom.xml)#56
Conversation
qxo
force-pushed
the
supportNoPom
branch
2 times, most recently
from
77b1456 to
d8ecbdb
Compare
ppalaga
left a comment
ppalaga
left a comment
There was a problem hiding this comment.
The idea and implementation look good in themselves. Two details are missing from my point of view:
-
Please change the commit message to what the PR is actually implementing and please use proper English spelling.
-
Please add an integration test in
EditorConfigMojosTest.
Sorry for my poor english, I'll check if I have the time:) |
Sorry, please do not take me wrong. The main issue is that the commit message speaks of two alternatives out of which only one is implemented. I mean, For spelling, using an in-browser spell checker would be enough to catch things like |
editorconfig-maven-plugin/src/main/java/org/ec4j/maven/AbstractEditorconfigMojo.java
Show resolved
Hide resolved
qxo
force-pushed
the
supportNoPom
branch
3 times, most recently
from
b510c3d to
c3662c9
Compare
qxo
changed the title
make this plugin goals can run on any project which has .editorconfig on project basedir such as with -Deditorconfig.basedir ``` mvn org.ec4j.maven:editorconfig-maven-plugin:0.1.x:format -Deditorconfig.includes=**/*.xml -e -Deditorconfig.encoding=UTF-8 -Dproject.basedir=/any_dir_with_editorconfig ``` or without editorconfig.basedir means on current dir ``` mvn org.ec4j.maven:editorconfig-maven-plugin:0.1.x:format -Deditorconfig.includes=**/*.xml -e -Deditorconfig.encoding=UTF-8 ``` or
|
@qxo sorry for the long delay. This PR still requires
|
3 participants
make this plugin goals run on any project which has .editorconfig on project basedir
such as with -Deditorconfig.basedir
or
without editorconfig.basedir means on current dir
or