refactor: baselineUsed type byte -> qboolean - #415
Open
WofWca wants to merge 1 commit into
Open
Conversation
`qboolean` is a more "narrow" type, makes it clear that e.g. there is no difference between `1` and `255`.
Contributor
|
Technically this increase size of the struct because sizeof qboolean would be size of int iirc compared to sizeof byte. |
Author
|
Yes, I thought of that. But that would probably increase performance then (dealing with full ints is easier than dealing with bytes). The compiler probably knows what it's doing. If not, then I don't think that it's a big deal anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qbooleanis a more "narrow" type, makes it clear that e.g.there is no difference between
1and255.