refactor: coalesce overlapping local key expiry warnings#108
Merged
Conversation
…Identity Introduce LocalKeyIdentity and LocalKeyPairExpiry so the local PrivateKey, its sibling PublicKey, signer identity, and recipient identity can be matched in one place. Use the match to suppress the duplicate "signer key expires" and "recipient key expires" warnings whenever they reference the same local key as the existing "Local key expires" warning, and rename "Private key" warnings to "Local key" to reflect that both PrivateKey and PublicKey expirations are now considered (the stricter status wins). Also collapse warning bodies from the previous two-line "expires in N days.\nExpires at: ..." format to a single line, and reuse approved signer key decisions when reviewing write recipient trust so the operator is not re-prompted for the same key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan