refactor: defer base directory resolution and decouple option resolvers#107
Merged
ebisawa merged 1 commit intoMay 27, 2026
Merged
Conversation
…decouple option resolvers Workspace resolution now accepts a closure for lazy base directory resolution, avoiding unnecessary computation when the base directory is not needed. Also separates resolve_options_with_allow_expired_key from allow_non_member validation to prevent unrelated config errors. Updates user guide command references with new CLI options.
ebisawa
deleted the
refactor/lazy-workspace-resolution-and-option-decoupling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_options_with_allow_expired_keyfromresolve_options_with_read_trust_allowancesso that commands using only--allow-expired-keyare not affected by invalidallow_non_memberconfiguration--allow-non-memberand--allow-weak-passwordoptionsTest plan
app_context_resolves_workspace_from_options_home_config_without_secret_env_hometest to verify lazy resolution pathtest_resolve_options_with_allow_expired_key_ignores_allow_non_member_configtest to verify decoupled behaviortest_resolve_options_with_read_trust_allowances_rejects_invalid_allow_non_member_configtest to verify validation still applies where expected