feat: migrate plugin execution from Docker-in-Docker to disk-based exec#5
Merged
Conversation
Replace Docker-in-Docker plugin execution with direct process execution via exec.CommandContext. Plugins are binary files or scripts mounted via a Docker volume and executed directly inside the service container. Changes: - Replace DockerConfig with PluginConfig (command/env/timeout) - Rewrite plugin.Generate() to use exec.CommandContext - Add ValidateConfig with path traversal protection - Environment isolation: only config.env propagated, no service secrets - Process group isolation: Setpgid + SIGKILL on timeout/cancel - Output size limiting via io.LimitReader - Per-plugin timeout support - Remove Docker exit codes from isTransient() - Update TracingPlugin spans: docker.exec -> process.exec - Dockerfile: debian:bookworm-slim, no docker-cli, VOLUME /plugins - SQL migration: docker config -> command format - Comprehensive test suite with mock plugin binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Docker-in-Docker plugin execution with direct process execution via exec.CommandContext. Plugins are binary files or scripts mounted via a Docker volume and executed directly inside the service container.
Changes: