Use downloaded crates in SnapATAC2-2.9.0 #24643
Open
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)Requires:
Cargo.tomlfile with workspace file easybuild-easyblocks#3988CargoPythonPackagethe default class for extensions/components ofCargoPythonBundleeasybuild-easyblocks#3993Can be tested with just easybuilders/easybuild-easyblocks#3993 and easybuilders/easybuild-easyblocks#3995 which includes the other cargo changes
General question: What shall we do when
cratesare given butoffline = Falselike in this case?offline=Falsewe do not add the "source overrides" and the folder where the crates are extracted to is essentially unused as Cargo doesn't know it even existsCARGO_NET_OFFLINEnothing will be downloaded at allOptions:
cratesandoffline=Falseis givenprint_warningonlyofflinebut for crates.io only if there are crates.iocratesset. This allows downloading of e.g. git sources when not given incrates. This allows some flexibility but I don't know if we ever need that or if it would work.