Conversation
Contributor
Author
|
@mitsuhiko gentle ping — small TUI fix when you have a moment. Skill autocomplete was nocase-fuzzying the full CI green, mergeable, fixes #8813. Happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix skill slash autocomplete ranking for bare queries.
Problem
Skill commands are fuzzy-matched using the full
skill:<name>string. The fixedskill:prefix can influence the score more than the actual skill name. With these loaded skills:skill:deep-researchskill:research-ideatyping
/idearankedskill:deep-researchaboveskill:research-ideain a local reproduction. The expected result isskill:research-idea, becauseideaoccurs in the bare skill name.Changes
/skill:...queries.Fixes #8813
Validation
npm -w packages/tui test: passednpm run check: passed./test.sh: has unrelated failures in other workspace/generated-model tests in this checkout; thepackages/tuitests and checks pass.This PR was prepared with AI assistance and reviewed by the contributor.