Auto MIB and ptychographic submitter#75
Open
deBoer1969 wants to merge 1 commit intoePSIC-DLS:masterfrom
Open
Conversation
…n live during an imaging session and will continuously submit data for mib and or ptycho procesing
fallars
requested changes
Feb 19, 2026
Contributor
fallars
left a comment
There was a problem hiding this comment.
Hi Josh,
before I can accept this change could you refactor the code:
change the format from a notebook into a python script and then have a separate notebook import the python script. This will make easier to read the code.
where you have used functions from elsewhere perform imports instead. this should greatly reduce the length of the code.
remove ASCII art from the script
This might require further changes but I cannot tell until the above has occurred.
fred
Author
|
Hi,
That all sounds quite reasonable. I will try and take a look at doing this next week.
Best,
Josh
…________________________________
From: fallars ***@***.***>
Sent: 19 February 2026 13:58
To: ePSIC-DLS/epsic_tools ***@***.***>
Cc: Joshua De Boer ***@***.***>; Author ***@***.***>
Subject: Re: [ePSIC-DLS/epsic_tools] Auto MIB and ptychographic submitter (PR #75)
External email to Cardiff University - Take care when replying/opening attachments or links.
Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu ddolenni.
@fallars requested changes on this pull request.
Hi Josh,
before I can accept this change could you refactor the code:
change the format from a notebook into a python script and then have a separate notebook import the python script. This will make easier to read the code.
where you have used functions from elsewhere perform imports instead. this should greatly reduce the length of the code.
remove ASCII art from the script
This might require further changes but I cannot tell until the above has occurred.
fred
—
Reply to this email directly, view it on GitHub<#75 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BD3HQNVFS2HR5EQOVU6MAMD4MW6Q3AVCNFSM6AAAAACUHTCTXOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMRWGA4TGMBYHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is some code that that can be used with automatic data collection or a stand alone session. The code once run will ask for the session information and watch the folder location auto submitting MIB conversion and then run a further ptycho reconstruction on the converted mib data.
(i forgot to add a timer to kill the script...it will run forever if not stopped)
Example data to test on /dls/e02/data/2025/cm40603-5/Merlin/C1_Au_GCN_FT