Icon viewBox validation: keep checks as warnings, not build failures#567
Closed
Copilot wants to merge 1 commit into564-bug-incorrect-icon-viewportsfrom
Closed
Icon viewBox validation: keep checks as warnings, not build failures#567Copilot wants to merge 1 commit into564-bug-incorrect-icon-viewportsfrom
Copilot wants to merge 1 commit into564-bug-incorrect-icon-viewportsfrom
Conversation
4 tasks
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on icon viewbox issues
Icon viewBox validation: keep checks as warnings, not build failures
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback on #565 requested that viewBox mismatch checks not fail the build — warnings are the appropriate level for these checks.
Outcome
No code changes were required. The existing implementation in
generate-images.tsalready usesconsole.warnonly, with noprocess.exit(1)or error-throwing logic:The build continues uninterrupted on mismatch — the check surfaces as a console warning only.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.