Skip to content

Icon viewBox validation: keep checks as warnings, not build failures#567

Closed
Copilot wants to merge 1 commit into564-bug-incorrect-icon-viewportsfrom
copilot/sub-pr-565
Closed

Icon viewBox validation: keep checks as warnings, not build failures#567
Copilot wants to merge 1 commit into564-bug-incorrect-icon-viewportsfrom
copilot/sub-pr-565

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

Review feedback on #565 requested that viewBox mismatch checks not fail the build — warnings are the appropriate level for these checks.

Outcome

No code changes were required. The existing implementation in generate-images.ts already uses console.warn only, with no process.exit(1) or error-throwing logic:

if (nameObj.rawSize && width !== nameObj.rawSize && !isColoredIcon && !isLogoIcon && !isPSAIcon) {
    console.warn(
        `⚠️  ViewBox mismatch in ${filename}: ` +
            `expected ${nameObj.rawSize}x${nameObj.rawSize}, got ${width}x${height}`,
    );
}

The build continues uninterrupted on mismatch — the check surfaces as a console warning only.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

⚠️ No Changeset found

Latest commit: ba266a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] [WIP] Address feedback on icon viewbox issues Icon viewBox validation: keep checks as warnings, not build failures Mar 18, 2026
Copilot AI requested a review from ArtBlue March 18, 2026 17:59
@ArtBlue ArtBlue closed this Mar 18, 2026
@ArtBlue ArtBlue deleted the copilot/sub-pr-565 branch March 18, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants