Skip to content

Fix/accordion anim #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LuLaValva merged 4 commits into from
Mar 12, 2026
Merged

Fix/accordion anim #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39bf8ca
fix: stuttering accordion animation
Mar 6, 2026
e72c98e
chore: add dist
Mar 6, 2026
6295073
chore: changeset
Mar 11, 2026
8cf89d1
test: update css snapshot for accordion
Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-cougars-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": patch
---

Adjust accordion open/close animation to avoid jumpiness
12 changes: 6 additions & 6 deletions packages/ebayui-core/src/components/ebay-accordion/test/__snapshots__/test.browser.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ exports[`accordion > given the accordion in the default state > then it matches
transition-delay: 0ms;
transition-duration: 0ms;
transition: height var(--motion-duration-medium-3) var(--motion-easing-standard),
content-visibility var(--motion-duration-medium-2)
content-visibility var(--motion-duration-medium-3)
var(--motion-easing-continuous) allow-discrete,
opacity var(--motion-duration-medium-2)
var(--motion-easing-continuous)
Expand Down Expand Up @@ -147,11 +147,11 @@ exports[`accordion > given the accordion in the default state > then it matches
</summary>
<div style="
animation-duration: 0ms;
margin-bottom: 6px;
margin-left: 16px;
margin-right: 16px;
overflow-x: hidden;
overflow-y: hidden;
padding-block-end: 6px;
transition-delay: 0ms;
transition-duration: 0ms
">
Expand Down Expand Up @@ -196,7 +196,7 @@ exports[`accordion > given the accordion in the default state > then it matches
transition-delay: 0ms;
transition-duration: 0ms;
transition: height var(--motion-duration-medium-3) var(--motion-easing-standard),
content-visibility var(--motion-duration-medium-2)
content-visibility var(--motion-duration-medium-3)
var(--motion-easing-continuous) allow-discrete,
opacity var(--motion-duration-medium-2)
var(--motion-easing-continuous)
Expand Down Expand Up @@ -303,11 +303,11 @@ exports[`accordion > given the accordion in the default state > then it matches
</summary>
<div style="
animation-duration: 0ms;
margin-bottom: 6px;
margin-left: 16px;
margin-right: 16px;
overflow-x: hidden;
overflow-y: hidden;
padding-block-end: 6px;
transition-delay: 0ms;
transition-duration: 0ms
">
Expand Down Expand Up @@ -351,7 +351,7 @@ exports[`accordion > given the accordion in the default state > then it matches
transition-delay: 0ms;
transition-duration: 0ms;
transition: height var(--motion-duration-medium-3) var(--motion-easing-standard),
content-visibility var(--motion-duration-medium-2)
content-visibility var(--motion-duration-medium-3)
var(--motion-easing-continuous) allow-discrete,
opacity var(--motion-duration-medium-2)
var(--motion-easing-continuous)
Expand Down Expand Up @@ -458,11 +458,11 @@ exports[`accordion > given the accordion in the default state > then it matches
</summary>
<div style="
animation-duration: 0ms;
margin-bottom: 6px;
margin-left: 16px;
margin-right: 16px;
overflow-x: hidden;
overflow-y: hidden;
padding-block-end: 6px;
transition-delay: 0ms;
transition-duration: 0ms
">
Expand Down
5 changes: 3 additions & 2 deletions packages/skin/dist/accordion/accordion.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ ul.accordion details {
}

ul.accordion details .details__content {
margin: 0 16px 6px;
margin: 0 16px;
overflow: hidden;
padding-block-end: 6px;
}

ul.accordion
Expand Down Expand Up @@ -82,7 +83,7 @@ ul.accordion--large summary.details__summary {
overflow: clip;
transition:
height var(--motion-duration-medium-3) var(--motion-easing-standard),
content-visibility var(--motion-duration-medium-2)
content-visibility var(--motion-duration-medium-3)
var(--motion-easing-continuous) allow-discrete,
opacity var(--motion-duration-medium-2)
var(--motion-easing-continuous);
Expand Down
5 changes: 3 additions & 2 deletions packages/skin/src/sass/accordion/accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ ul.accordion details {
}

ul.accordion details .details__content {
margin: 0 16px 6px;
margin: 0 16px;
overflow: hidden;
padding-block-end: 6px;
}

ul.accordion
Expand Down Expand Up @@ -87,7 +88,7 @@ ul.accordion--large summary.details__summary {
overflow: clip;
transition:
height var(--motion-duration-medium-3) var(--motion-easing-standard),
content-visibility var(--motion-duration-medium-2)
content-visibility var(--motion-duration-medium-3)
var(--motion-easing-continuous) allow-discrete,
opacity var(--motion-duration-medium-2)
var(--motion-easing-continuous);
Expand Down
Loading