This repository was archived by the owner on Apr 25, 2025. It is now read-only.
fix: honor snackbar dialog input.open if type boolean#2479
Closed
janenath wants to merge 2 commits intoeBay:15.3.0from
janenath:snackbar-dialog-on-input-fix
Closed
fix: honor snackbar dialog input.open if type boolean#2479janenath wants to merge 2 commits intoeBay:15.3.0from janenath:snackbar-dialog-on-input-fix
janenath wants to merge 2 commits intoeBay:15.3.0from
janenath:snackbar-dialog-on-input-fix
Conversation
🦋 Changeset detectedLatest commit: 816597f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LuLaValva
approved these changes
Apr 10, 2025
Member
LuLaValva
left a comment
LuLaValva
left a comment
There was a problem hiding this comment.
Looks great! Thanks for finding & fixing the bug!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix logic for
ebay-snackbar-dialogonInput()function to correctly update open state based on inputContext
Updating
ebay-snackbar-dialogopen input tofalse,<ebay-snackbar-dialog open=state.open />, does not close the snackbar component. The current logic is overridinginput.opento usethis.state.openifinput.openis falsy, preventing the snackbar from closing. This code change honorsinput.openif it's type boolean before falling back tothis.state.open.References
Issue: eBay/evo-web#7
Screenshots
Before
Screen.Recording.2025-04-10.at.10.17.09.AM.mov
After
snackbar-fix.mov