Skip to content

Use workflow to release firecracker instead#17

Merged
djeebus merged 11 commits intomainfrom
use-workflow-instead
Apr 17, 2026
Merged

Use workflow to release firecracker instead#17
djeebus merged 11 commits intomainfrom
use-workflow-instead

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Apr 17, 2026

No description provided.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 17, 2026

PR Summary

Medium Risk
Changes the release automation path (tagging, uploading to GCS, and GitHub release assets) and introduces new validation logic, so misconfiguration could impact published binaries or skip needed builds.

Overview
Switches from the previous push-driven, firecracker_versions.txt matrix build to a manual release.yml workflow that resolves a tag/commit, checks CI status, detects existing artifacts in GCS/GitHub Releases, and only builds missing amd64/arm64 binaries before uploading.

Adds scripts/validate.py (with pytest coverage + a new Tests workflow and Poetry tooling) to perform the input/CI/artifact checks, and simplifies build.sh to build directly from a commit hash and write only the per-arch output layout. Updates docs/tooling (README.md, .tool-versions, .gitignore) and removes the old workflows and parsing/CI-check scripts.

Reviewed by Cursor Bugbot for commit 2db53f2. Bugbot is set up for automated code reviews on this repo. Configure here.

@djeebus djeebus marked this pull request as ready for review April 17, 2026 21:31
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread build.sh Outdated
Copy link
Copy Markdown
Member

@ValentaTomas ValentaTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3c21eb3. Configure here.

Comment thread scripts/validate.py Outdated
Comment thread .github/workflows/test.yml Fixed
@djeebus djeebus merged commit 9088a51 into main Apr 17, 2026
2 of 3 checks passed
@djeebus djeebus deleted the use-workflow-instead branch April 17, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants