Skip to content

Conversation

@cbou
Copy link
Contributor

@cbou cbou commented Sep 10, 2025

This PR allow the user to skip the javascript regex validation for filters. Filters in the ContentAPI are not necessarily compatible with JavaScript Regex. For example (?i).*example.* works in ContentAPI but not in JavaScript.

@jodeleit-es
Copy link
Collaborator

jodeleit-es commented Sep 10, 2025

Hi, the change looks correct and minimal 👍
This will fix #204
Could you please add a corresponding test case, it should sit here: https://github.com/e-Spirit/javascript-content-api-library/blob/master/src/modules/QueryBuilder.spec.ts#L825

@cbou
Copy link
Contributor Author

cbou commented Sep 11, 2025

Hello @jodeleit-es,
Thanks. I added the test. Is it ok for you?

@nico-mcalley nico-mcalley merged commit 5937e64 into e-Spirit:master Sep 22, 2025
2 of 3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 22, 2025
# [10.24.0](v10.23.0...v10.24.0) (2025-09-22)

### Features

* **QueryBuilder:** Make regex validation filter optional ([#227](#227)) ([5937e64](5937e64))
@github-actions
Copy link

🎉 This PR is included in version 10.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants