Check the correct buffer to detect change in the CtrlSFClose command #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dyng merged 1 commit into dyng:master from vds2212:ctrlsfclose-check

Apr 15, 2025

Contributor

vds2212 commented Apr 14, 2025

This pull request intent to solve issue #350.


          check the correct buffer to detect change in the CtrlSFClose command

6e42b76

Owner

dyng commented Apr 15, 2025

Thank you for your fix!

dyng merged commit ba1f580 into dyng:master

Contributor Author

vds2212 commented Apr 15, 2025

Thanks for accepting it :-)

I also submitted three other pull request:

one to make CtrlSF to be robust to change of working directory Use the working folder of the search to used it to open the result file. #345
one to support alternative encoding, provided by rg Add support for the encoding flag. #348 and
one to support backslash in pattern Don't escape backslash in patterns to allow backslash in patterns #347

Did you had the chance to have a look to it?
Is it something I can do to improve them or to make it easier for you to validate them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet